[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] comment stripping in config files

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-04-28 00:26:59 CEST

On 4/27/06, C. Michael Pilato <cmpilato@collab.net> wrote:
> Greg Hudson wrote:
> > On Thu, 2006-04-27 at 11:16 -0700, Garrett Rooney wrote:
> >
> >>I've got a patch to fix this by stripping comments from values in the
> >>config parser code, but I hesitate to change the behavior of this sort
> >>of thing since someone might depend on it.
> >
> >
> > What does Python do? We didn't invent the config file format, and we
> > don't own it.
>
> Python treats lines for which the # is not the first character literally.
> So an option like:
>
> checkout_magic = # 0
>
> is parsed as having a value '# 0',

Ok, so clearly we can't change this in the config parser. The correct
fix will have to be something in the authz code.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 28 00:27:30 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.