[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: wcprops dir left after upgrading WC

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-04-26 21:54:49 CEST

Ivan Zhakov writes:
> On 4/26/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > Ivan Zhakov writes:
> > > What do you think about this patch:
> > > [[
> > > Remove wcprops directory when upgrade WC to format 8.
> > >
> > > * subversion/libsvn_wc/lock.c
> > > (convert_wcprops): Add log commands to remove wcprops directory and
> > > dir-wcprops file.
> >
> > Couldn't we just remove the directory and file before running the log ignoring
> > the error? It is no catastrophy if that fails. Same for README and
> > empty-file.
> >
> I dislike such behavior. It's error and we shouldn't silently ignore any error.

My reasoning is that it is so harmless if it happens that actually reporting
it makes more harm by confusing users, but I'm not really objecting.

> But there is another idea: might we can remove directory and files
> between writing and running logs?
>

This is problematic if deleting wcprops fails. Then, when cleanup is run,
these dirs will be left behind. No real harm, just some waste of
urser's disk space, but users could always recheckout if that's a real problem.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 26 21:55:11 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.