Re: Resolving issue 2431 as invalid? (blame ignore eol-style)

On 4/22/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Erik Huelsmann writes:
> > Giving this issue much thought, I came to the conclusion the issue
> > should be resolved as INVALID and all associated commits should be
> > reverted: blame output is command line output. This means it should
> > use the platform default EOL style, not what happens to be in the
> > eol-style property.
>
> +1. Mainly because this output isn't fed to a program that will use it as the
> raw contents. OTOH, the blame code should look for all eol styles,
> which I'm not sure if it does currently.

That's right. The current diff code - as I understand it - has a
helper to estimate the current file's eol style. The blame algorithm
generating the final output doesn't use this helper yet. It surely
could be updated to do so though.

Since blame uses diff internally, I presume it does use the helper to
find the deltas.

bye,

Erik.
Received on Sat Apr 22 22:26:36 2006