[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Reporting subtree deletes through svn_delta_editor_t?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-04-21 21:07:15 CEST

Malcolm Rowe writes:
> The first is to pause whenever we see a delete_entry and separately
> traverse the deleted subtree. I've already added code for repos->WORKING
> diffs to do this (which is easy because we need to traverse the local wc),
> but it's fragile and doesn't work for repos-BASE or WORKING->repos diffs
> (where we'd need to contact the repository).
>
> Also note that if we did this for repos-repos diffs, we'd need to use at
> least three connections: one to receive the report request, a second to
> traverse the deleted subtrees, and a third to fetch the contents of files.
>

I've been in the diff code (but not in any way as much as you), so I know
that this is complicated stuff, so excuse me for a silly question...

Why couldn't you just "check out" the deleted directory in the source revision
interpreting adds as deletes. This wouldn't require a third session
and it would work with old servers. I can't see why this shouldn't
work for repos-repos diffs, but I'm not sure for repos-BASE. Is there
an issue with mixed revisions or can that be handled on the client
side?

If we have to extend the editor interface, there's nothing we can do,
but I would like to avoid clutttering it if possible.

On a side note, you can't do delete_entry after having opened a
directory
according to restriction 1. of the editor interface documentation, so
we need something new here.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 21 21:07:50 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.