Re: [PATCH] small clarity fix for vdelta implementation

Kamesh Jayachandran wrote:
> Hi All,
> Trying to understand the vdelta implementation in subversion.
> I have the following clarity suggestion to the code.
> In the vdelta(): current_match_len can either be 0 or >= to VD_KEY_SIZE.
> The 'no-match check' of (current_match_len < VD_KEY_SIZE) can be
> simplified to
> (!current_match_len) for clarity.
IIRC, the match _can_ be shorter than the key size. at least, you can
see shorter "new" and "copy" instructions in the delta.

I can't tell without looking at more of the vdelta code, which I can't
do right now.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 20 09:22:47 2006