Re: svn_client_log3() doesn't work as advertised

Philip Martin wrote:
> Stefan Küng <tortoisesvn@gmail.com> writes:
>
>> The same happens with the SVN client on windows.
>> But I suspect that it simply ignores the peg revision you pass on the
>> command line - you'll get the same if you don't pass it.
>>
>> The problem really is in the svn_client_log3() function.
>
> Breakpoint 2, svn_client_log3 (targets=0x808c730, peg_revision=0xbffff8f4,
> start=0xbffffa5c, end=0xbffffa68, limit=100, discover_changed_paths=1,
> strict_node_history=0, receiver=0x8050c18 <log_message_receiver>,
> receiver_baton=0xbffff900, ctx=0x8087da0, pool=0x8068f38)
> at ../svn/subversion/libsvn_client/log.c:63
> 63 const char *base_name = NULL;
> (gdb) p peg_revision[0]
> $1 = {kind = svn_opt_revision_number, value = {number = 4, date = 4}}
> (gdb) p start[0]
> $2 = {kind = svn_opt_revision_number, value = {number = 2, date = 2}}
> (gdb) p end[0]
> $3 = {kind = svn_opt_revision_number, value = {number = 1, date = 1}}
> (gdb) p ((char**)(targets[0].elts))[0]
> $4 = 0x808c918 "wc/trunk/file2"
>
> The peg revision appears to get as far as svn_client_log3.

Sorry, my fault. I found what's wrong in the recipe:

svnadmin create repo
svn co file:///d:/repo wc
cd wc
svn mkdir trunk
echo test > trunk\file
echo test > trunk\file1
svn add trunk\file
svn add trunk\file1
svn ci -m "log 1"
echo test2 > trunk\file
svn ci -m "log 2"
echo test2 > trunk\file1
svn ci -m "log 3"
svn ren trunk\file trunk\file2
svn ci -m "log 4"
echo test > trunk\file2
svn ci -m "log 5"

Now, an
svn log trunk\file2@5 -r3:1
fails.

Seems it doesn't recognize that trunk\file2 was still named trunk\file
in revision 3 and only renamed in revision 4.

And the problem with passing svn_opt_revision_working as the peg
revision is still valid. But seems it's not possible to pass that peg
revision with the command line client.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org