Garrett Rooney <rooneg@gmail.com> wrote:
> On 4/18/06, Marc Sherman <msherman@projectile.ca> wrote:
> > Ben Collins-Sussman wrote:
> > >
> > >> If a file is a member of a changelist and it's committed, is it
> > >> removed from the changelist?
> > >>
> > >
> > > Yes. A very strange corner case, though, since presumably the
whole
> > > reason it was part of the changelist in the first place was so
that it
> > > could be committed as part of a larger change.
> >
> > It might be helpful to error out in that case, and require --force
to
> > continue.
>
> It's not possible to detect that case with the current design for
> changelists that Ben has put forth. If membership in a changelist is
> controlled by a property of some sort on the file, you have no way to
> determine that you've got all of the members of the list in a commit.
> What if a file in another part of the working copy (a sibling of the
> root dir you passed to 'commit') is in the changelist?
Just looking at this from a user's point of view - I think it's
possible that they'll make changes, unrelated to the changelist, to
a file and commit it. That'll end up committing the changes intended
to be grouped within the changelist.
It may not be possible to prevent this chain of actions, but we should
expect that this will result in a few "surprised" users.
-Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 18 20:18:55 2006