[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svncopy.pl externals tag fix

From: David James <djames_at_collab.net>
Date: 2006-04-18 04:22:41 CEST

On 4/17/06, Michael W Thelen <mike@pietdepsi.com> wrote:
> Michael W Thelen wrote:
> > Thank you for the patch! It looks like the original code was probably
> > intending to make the space optional, but wrongly used \s+? instead of
> > \s*. Since the $morespacing variable is never used in your patch,
> > there's really no need to capture it. Something like the patch below
> > might be cleaner. Unfortunately I can't test it at the moment. Would
> > someone be willing to try it out and either approve or commit it?
>
> I did get around to testing this patch after tweaking it again slightly,
> and it works as expected.

+1 to commit.

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 18 04:23:20 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.