[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Issue #1997

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-04-17 21:13:54 CEST

On 4/17/06, Paul Burba <paulb@softlanding.com> wrote:
> A V5R4 user on the OS400 list reported a problem with svnadmin verify
> yesterday. Turns out to be a manifestation of issue #1997. The fix seems
> so painfully straightforward that I fear I might be missing something(?)
>
> If someone has a moment to check this out I'd appreciate it, thanks,

Looks reasonable to me, although you're putting spaces between your
functions and parens, which we don't do anymore, and the rest of the
places in this code that do the recode_write stuff conditionalize it
on opt_state->quiet, so it seems like this part probably should as
well. Although on the other hand, we've been creating a stderr stream
unconditionally for a while now, so perhaps we should just leave it
regardless of the quiet setting.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 17 21:14:32 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.