[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The nonxml-entries branch

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-04-13 09:46:44 CEST

Philip Martin writes:
> "Peter N. Lundblad" <peter@famlundblad.se> writes:
>
> [performace figures that look good]
>
> > I strongly feel this branch should be merged and would like some
> > review if possible.
>
> I've had a look at the code (not compiled or tested) and it looks good
> to me, I think it should be merged. Two comments so far:

Thanks for reviewing. As you may have noticed, I had to fix a case
where running cleanup on a WC in the old format would break the WC by
installing the new entries file in the new format, tithout upgrading
the rest of the WC. Do you care to take a look at the upgrading
strategy and see if it looks sane now?

> - there is broken indentation around line 1090 in entries.c.

Wow! Some obfuscation might not hurt, right? :-) F(Fixed now).

> - when writing the entries perhaps make a guess at the overall size
> (use the number of entries?) and pre-allocate bigstr to avoid some
> of the my_realloc calls.
>

I profiled a checkout (which is pretty write_entries intensive) and
I'm not sure it would make any difference. memcpy has about 7% of the
execution time, and that includes txdelta appplication and
libsvn_ra_svn protocol handling.. It might not hurt either, so I
wouldn't object...

Best Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 13 09:47:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.