Re: [PATCH] [RUBY] new typemaps

Hi,

Thanks for sending many patches.

In <92f5f81d0604121800l5cdf48f2yacc461d72bf2a3cd@mail.gmail.com>
  "[PATCH] [RUBY] new typemaps" on Wed, 12 Apr 2006 18:00:44 -0700,
  "Evan Phoenix" <evan@fallingsnow.net> wrote:

> This patch adds a couple of new SWIG typemaps so that everywhere that
> can receive a delta editor works the same.
>
> Also adds another entry to the MAY_BE_NULL char* list.

I prefer to have a change in a patch than some changes in a
patch.

> * subversion/bindings/swig/ruby/svn_delta.c
> * subversion/bindings/swig/ruby/svn_ra.c
> SWIG autogenerated changes.

This files don't need.
I suggest you use working copy of
https://svn.collab.net/repos/svn/trunk.

> * subversion/bindings/swig/svn_delta.i
> (const char *MAY_BE_NULL) text_checksum can optionally be NULL

Where is it needed?

> * subversion/bindings/swig/svn_ra.i
> Added typemaps for delta_editors with edit_baton, update_baton, and
> diff_baton arguments. This allows any object to serve as editors in these
> places. Code is actually duplicated from the same file, all that was done is
> altering the name of the baton. Anywhere that accepts a delta_editor should
> work the same now.

Could you update test cases too?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org