Julian Foad <julianfoad@btopenworld.com> wrote on 04/10/2006 10:51:56 AM:
> Paul Burba wrote:
> > Sorry for the delay in getting back to this. Let me know if this is
what
> > you all had in mind.
> >
> > Paul B.
> >
> > [[[
> > Rev svn_utf_cstring_*_utf8_ex so xlate_handle_node_t structs are
> > cached based on the conversion taking place rather than a string
> > key argument.
>
> Yes, this patch looks fine to me, though I haven't tested it.
Julian,
Just an FYI: I tested this via ra_local and ra_dav on Windows XP (Apache
2.0.54, Neon 0.24.7) with fsfs. I also ran my OS400 versions of the test
suite. No problems.
Also, FWIW, I ran two versions of the svnserve client tests side-by-side
against 1.3.1 on the iSeries, one with this change applied, one without,
trying to see if there was any noticeable performance difference (i.e. Did
the string manipulation now required for every call to svn_utf_*_utf8_ex2
show up in an appreciable way?). The OS400 port makes fairly heavy use of
the *_ex2 funcs since all the command line programs use it to convert
incoming EBCDIC args to UTF-8. Not exactly scientific, but they both ran
within a few seconds of each other. These tests take several hours to
complete on the iSeries so that seems an insignificant difference.
Paul B.
_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 12 15:10:18 2006