[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r19313 - trunk/subversion/tests/cmdline

From: Madan U S <madan_at_collab.net>
Date: 2006-04-12 09:02:17 CEST

oops, apologize for the unindented mail... here it comes again...

On Wed, 12 Apr 2006 04:00:52 +0530, <rooneg@tigris.org> wrote:
 
> Author: rooneg
> Date: Tue Apr 11 15:30:52 2006
> New Revision: 19313
>
> Modified:
> trunk/subversion/tests/cmdline/svnsync_tests.py
>
> Log:
> * subversion/tests/cmdline/svnsync_tests.py
> (run_test): Move checking for stderr output before checking
> for lack
> of stdout output. If there's no stdout data, it's likely
> because
> there is something on stderr, so showing the error is more
> useful.
>
>
> Modified: trunk/subversion/tests/cmdline/svnsync_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/
> cmdline/svnsync_tests.py?pathrev=19313&r1=19312&r2=19313
>
> =============================================================================
> --- trunk/subversion/tests/cmdline/svnsync_tests.py
> (original)
> +++ trunk/subversion/tests/cmdline/svnsync_tests.py
> Tue Apr 11 15:30:52 2006
> @@ -100,11 +100,11 @@
> "synchronize", dest_sbox.repo_url,
> "--username", svntest.main.wc_author,
> "--password", svntest.main.wc_passwd)
> + if errput:
> + raise svntest.actions.SVNUnexpectedStderr(errput)
> if not output:
> # should be: ['Committing rev 1\n', 'Committing rev 2\n']
> raise svntest.actions.SVNUnexpectedStdout("Missing
stdout")
> - if errput:
> - raise svntest.actions.SVNUnexpectedStderr(errput)
>

What happens if there is stdout *also*?
I think the right behavior should be
 
if errput:
   if output:
       print output
    raise svntest.actions.SVNUnexpectedStderr(errput)
if not output:
   raise svntest.actions.SVNUnexpectedStdout("Missing stdout")
 
     if you like this, I could send in a patch.
 
Regards,
Madan.
Received on Wed Apr 12 09:04:42 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.