[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn SONAMEs and APR

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-04-11 01:17:03 CEST

"Justin Erenkrantz" <justin@erenkrantz.com> writes:

> On 4/10/06, Philip Martin <philip@codematters.co.uk> wrote:
>> That doesn't really address my point. You probably know more than me,
>> but as I understand it backporting full LFS to APR 0.9.x is simple
>> except that it would be an unacceptable ABI change. Nothing you have
>> written explains why you are happy to make the same ABI change in
>> Subversion.
>
> I don't view APR's ABI as part of Subversion's.

I find that odd given that apr_off_t is part of Subversion's ABI.

>> > Even then, it's still very possible for LFS to be toggled on or off
>> > even in the same 'library' version of APR/APR-util. Same goes for
>> > threading, mmap, etc.
>>
>> I'm not really interested in corner cases, although I suspect that
>> threading is handled by 'apr-config --cflags' and that mmap doesn't
>> change the ABI.
>
> As Garrett points out, those features changes the ABI by adding or
> removing APR symbols.
>
>> > Those apps *should* be linking with libtool. If not, it's very likely
>> > that it may not compile or link appropriately.
>>
>> I disagree, libtool is optional.
>
> If your app happens to work without libtool, good for you; but
> removing libtool from the chain isn't something that we can support.

I don't understand, are you claiming that a third-party application
must use libtool?

>> Since nobody else appears to care about this problem I don't think
>> it's sensible to change the default. How about a configure option to
>> allow people to choose to get (or set?) a different SONAME? After all
>> it is simple to support http-2.0/apr-0.9 and http-2.2/apr-1.2 in
>> parallel so we should provide a standard way to do it even if it is
>> not the default.
>
> As I've said before, feel free to make it optional. However, you
> might run head-first into libtool to get it to set non-numeric custom
> SONAMEs - as it relies upon versions of the order X.Y.Z to set the
> SONAME. (See soname_spec, versuffix, etc.)
>
> My hunch is that Peter's Debian patch would tweak GNU libtool not
> Subversion as Subversion doesn't have much control over SONAMEs. --

Are we talking at cross purposes on libtool? I'm proposing a patch
along the lines of Peter's patch, but under some --enable-foo flag and
possibly restricting APR to either 0.9.x or 1.2.x

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 11 01:17:35 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.