[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] was: More documentation for svn_utf_cstring_from_utf8_ex()[Show] etc.

From: Paul Burba <paulb_at_softlanding.com>
Date: 2006-04-10 14:11:41 CEST

Julian Foad <julianfoad@btopenworld.com> wrote on 03/26/2006 08:15:24 AM:

> Peter N. Lundblad wrote:
> > I think both of these are too messy for little gain.
>
> Well, I'd describe the first idea (requiring initialisation) as the
> "tidy" way
> in terms of its result (and I'm sure we'll want to do it sooner or
> later), but
> if you mean it's too much code churn for this particular gain then Ican
agree
> with you.
>
>
> After all that, I'm happy for you (Paul) to go with something like what
you
> had, but probably "revving" the API as Peter mentioned because I don't
really
> see a benefit in not doing so.
>
> - Julian

Hello,

Sorry for the delay in getting back to this. Let me know if this is what
you all had in mind.

Paul B.

[[[
Rev svn_utf_cstring_*_utf8_ex so xlate_handle_node_t structs are
cached based on the conversion taking place rather than a string
key argument.

* subversion/include/svn_utf.h
  (svn_utf_cstring_to_utf8_ex2, svn_utf_cstring_from_utf8_ex2): New.
  (svn_utf_cstring_to_utf8_ex, svn_utf_cstring_from_utf8_ex):
  Deprecate.

* subversion/libsvn_subr/cmdline.c
  (SVN_UTF_CONTOU_XLATE_HANDLE, SVN_UTF_UTOCON_XLATE_HANDLE,
  SVN_UTF_ETOU_XLATE_HANDLE): Remove.
  (svn_cmdline_cstring_from_utf8, svn_cmdline_cstring_to_utf8,
  svn_cmdline__getopt_init): Change calls to svn_utf_cstring_*_utf8_ex
  to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/io.c
  (SVN_UTF_ETOU_XLATE_HANDLE, SVN_UTF_UTOE_XLATE_HANDLE): Remove.
  (svn_io_create_unique_link, svn_io_read_link): Change calls to
   svn_utf_cstring_*_utf8_ex to use svn_utf_cstring_*_utf8_ex2.

* subversion/libsvn_subr/utf.c
  (get_xlate_key): New function.
  (convert_cstring): Update doc string.
  (svn_utf_cstring_to_utf8_ex2): New.
  (svn_utf_cstring_to_utf8_ex): Reimplement as wrapper around
  svn_utf_cstring_to_utf8_ex2.
  (svn_utf_cstring_from_utf8_ex2): New.
  (svn_utf_cstring_from_utf8_ex): Reimplement as wrapper around
  svn_utf_cstring_from_utf8_ex2.

* subversion/libsvn_client/diff.c,
  subversion/libsvn_diff/diff_file.c,
  subversion/libsvn_repos/hooks.c,
  subversion/libsvn_subr/stream.c,
  subversion/libsvn_subr/subst.c,
  subversion/svn/util.c:
  Change all callers of svn_utf_cstring_*_utf8_ex to use
  svn_utf_cstring_*_utf8_ex2.
]]]

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Apr 10 14:12:28 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.