Stefan Haller writes:
> Looking back through the postings in this thread, quite a lot of people
> were in favour of applying the patch in this form. Only Justin
> Erenkrantz opposed; the objection was that the patch is incomplete, for
> example it doesn't flush diff output. That's correct, but fixing this
> would require much bigger changes than I feel is justified for this; as
> I see it, it would require adding a callback to svn_client_diff3 and
> svn_client_diff_peg3, and changing the svn_wc_diff_callbacks2_t vtable
> to store this callback. I don't think it's worth that, especially since
As I think I pointed out somewhere, you can solve this by adding a notification
kind so the notify callback gets invoked after each diffed file
(this might be useful for GUIs as well). The cmdline client would just fflush
the output stream.
> May I ask for opinions again, please.
>
As before, I think this is a good idea, but I'm not going to do anything
with this (if we can convince Justin that is) until after 1.4 is branched.
I have more important things to do, syrro.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 9 18:41:22 2006