Re: svn commit: r19251 - trunk/subversion/libsvn_ra_serf

On 4/7/06, Justin Erenkrantz <justin@erenkrantz.com> wrote:
> On Fri, Apr 07, 2006 at 10:41:42PM -0700, Garrett Rooney wrote:
> > It seems like there should be some error checking on the rev
> > attribute, what if it isn't there?
>
> It depends how much checking we think is appropriate. ra_dav and ra_serf
> don't always generate errors on attribute omissions. *shrug*
>
> Look for "verify we got it. punt on error." in ra_dav/fetch.c. =)

Sure, but when I implemented replay in ra_dav I did make sure to check
for that sort of thing, so backsliding in ra_serf seems wrong ;-)

> > Similar things could be said for
> > the rest of the editor calls in this file.
>
> The editor calls are wrapped with SVN_ERR.

Sure, but are we sure all the places we pass potentially NULL
attribute strings actually deal with NULL arguments? Quite a few
places in svn explicitly don't, after all.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 8 08:38:13 2006