-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ivan Zhakov wrote:
> Hi!
> After 1.3.x in r17339 Erik Huelsman deprecated svn_wc_text_modified_p
> and replaced it with svn_wc_text_modified_p2 which has new parameter
> compare_textbases. svn_wc_text_modified_p calls
> svn_wc_text_modified_p2 with compare_textbases==TRUE.
>
> But we use svn_wc_text_modified_p2 with compare_textbases==FALSE only
> in one place and it is inside libsvn_wc.
> So, I propose don't leave svn_wc_text_modified_p2 in our public API.
>
> BTW: Other argue is that svn_wc_text_modified_p2 cannot be implemented
> with compare_textbases==FALSE for special files.
Additionally, the name 'svn_wc_text_modified_p2' feels weird to me - I'd
expect it to be 'svn_wc_text_modified2_p' if it were to remain public,
in line with the svn_foo_bar2_t convention we've adopted.
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
iD8DBQFENnIqfFNSmcDyxYARAmYBAKDRENUBXXmQstXNIRHNPD5/Ewmo6wCg2J3g
RDZ55PTyTI3SzKdRb+WKbak=
=cyFq
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 7 16:08:19 2006