[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: committing a rename with a delta editor

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-04-06 20:40:36 CEST

On Thu, 06 Apr 2006, C. Michael Pilato wrote:

> Daniel Rall wrote:
> > I've committed Geoff's patch as r19203, but given that Mike's research
> > shows that copyfrom_path is actually always a URI, I'm actually in
> > favor of doing the vtable function argument name change as well.
> > Anyone against?
>
> Actually, I'm against. Thus far, the copyfrom_path has always been a URI,
> but we only use that parameter *at all* in a select few places. I see no
> reason to paint ourselves into that corner right now. IMO, the docstring
> should state that the copyfrom_path is either a path relative to the root of
> the edit, or an absolute URL.

Thanks Mike, r19210.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Apr 6 20:41:33 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.