Re: committing a rename with a delta editor

On Wed, 05 Apr 2006, Geoff Richards wrote:
...
> > > * What form should the copyfrom_path value take? In the docs it
> > > just says that it should be a path, but it seems to require a
> > > full URL. When I try with just a path I get this:
> >
> > Looking at the code, I agree that it seems that the commit editors require
> > a URL.
>
> In that case, can I suggest the attached patch against r19185 to clarify
> the docs. Or perhaps it would be better to rename the argument to
> 'copyfrom_url'?

I've committed Geoff's patch as r19203, but given that Mike's research
shows that copyfrom_path is actually always a URI, I'm actually in
favor of doing the vtable function argument name change as well.
Anyone against?

...
> Index: subversion/include/svn_delta.h
> ===================================================================
> --- subversion/include/svn_delta.h (revision 19185)
> +++ subversion/include/svn_delta.h (working copy)
> @@ -590,9 +590,11 @@
> * @a copyfrom_path and @a copyfrom_revision. If @a copyfrom_path is
> * non-@c NULL, then @a copyfrom_path and @a copyfrom_revision indicate where
> * the file or directory should be copied from (to create the file
> - * or directory being added). If @a copyfrom_path is @c NULL, then
> - * @a copyfrom_revision must be @c SVN_INVALID_REVNUM; it is invalid to
> - * pass a mix of valid and invalid copyfrom arguments.
> + * or directory being added). In that case @a copyfrom_path must be the
> + * URL of a file inside the same repository as the new file or directory.
> + * If @a copyfrom_path is @c NULL, then @a copyfrom_revision must be
> + * @c SVN_INVALID_REVNUM; it is invalid to pass a mix of valid and invalid
> + * copyfrom arguments.
> *
> *
> * <h3>Function Call Ordering</h3>
>