[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19194 - in branches/fs-atomic-renames/subversion: include libsvn_delta libsvn_repos

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-04-06 11:09:01 CEST

rooneg@tigris.org writes:
> Author: rooneg
> Date: Wed Apr 5 17:37:49 2006
> New Revision: 19194
>
> Log:
> On the fs-atomic-renames branch:
>
> Rev the delta editor interface to support renames. In order to keep
> the diff small, this only revs the consumers of the delta editor that
> are necessary to support dump/load, all other consumers use the old
> version of the editor for the time being.

Oh, my! Here it goes:-)

> * subversion/include/svn_delta.h
> (svn_delta_editor2_t): New editor, includes rename specific functions
> and documents that it must be created via a constructor.
> (svn_delta_default_editor2): Constructor for new editor.

Should we take the oportunity to call this svn_delta_editor_create to use
a similar name to many other constructor functions?

...and I didn't read the whole diff:-)

When you do the bulk of this: change everything to use the new editor,
will you move that work to trunk, then? I really hope you will.
(Except for the rename stuff, of course).

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 6 11:09:29 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.