[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: resolve the unicode problem of mod_authz_svn apache mod

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-04-05 00:18:44 CEST

On 4/1/06, L mice <hehaoslj@gmail.com> wrote:
>
> here is my change:
> [mod_authz_svn.c]
> //add declare
> //++
> extern
> svn_error_t *
> svn_utf_cstring_from_utf8 (const char **dest,
> const char *src,
> apr_pool_t *pool);
>
>
> //in function req_check_access
> //add declare
> //++
> char* curi;
> svn_error_t* convert_error;
>
>
> //add before any call
> //++
> convert_error=svn_utf_cstring_from_utf8(&curi,r->uri,r->pool);
> if (convert_error)
> {
> curi = apr_pstrdup(r->pool, r->uri);
> }
>
>
> //change r->uri to curi
>
>
> dav_err = dav_svn_split_uri(r,
> curi,//r->uri,
> conf->base_path,
> &cleaned_uri,
> &trailing_slash,
> &repos_name,
> &relative_path,
> &repos_path);
>

We generally expect people to post changes in unified diff format, the
same thing you get from running 'svn diff'. On top of that, a clear
description of what steps can be used to reproduce this problem, and
why this is the correct fix would be far more likely to convince
someone to apply it than just sending the change to the mailing list.

Of the top of my head, I'm not sure this is correct, since I'd be kind
of surprised if it's always correct that the URI you get from Apache
is in utf8 form...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 5 00:19:49 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.