Paul Burba writes:
> "Peter N. Lundblad" <peter@famlundblad.se> wrote on 04/03/2006 09:46:19
> AM:
>
> > Paul,
> >
> > Today it occurred to me: since this is specific to a particular
> platform,
> > wouldn't it be possible to just use apr_os_file_get() (see
> apr_portable.h) to
> > avoid this poll mess altogether? Just duplicate the stdin file handle to
> > the stdin descriptor of the child process.
> >
> > (I was looking for this "get the native file handle" function before,
> > but didn't find it because I was looking in the wrong place. Sorry for
> > that:-()
>
> I had looked for something along these lines when wrestling with the
> "incompatability" between apr_file_t and OS400 file descriptors. Guess I
> didn't look in the right place either.
>
> > (If that doesn't work for some reason, I'll have a look at your new
> patch.)
>
> It works great and my patch is now greatly simplified. Or at least it's
> back to more or less the same state as 19004 but uses apr_os_file_get()
> and also applies some of the non-poll() related suggestions from your
> previous e-mail.
>
OK. My mailer seems to not understand your attachments (but the
archives does, so it might very well be on my side), so I'm too lazy
to quote the patch. It looks good except for a semicolon at the end of
the line witht the apr_os_file_get call, which should cause the code
to always return an error if there's a stdin handle:-)
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 3 21:41:18 2006