[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19108 - trunk/subversion/libsvn_ra_serf

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-03-31 20:41:39 CEST

On Thu, 30 Mar 2006, Greg Stein wrote:

> On Thu, Mar 30, 2006 at 05:08:59PM -0800, jerenkrantz@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_ra_serf/update.c Thu Mar 30 17:08:59 2006
> > @@ -1983,7 +1983,11 @@
> > }
> > if (status)
> > {
> > - return svn_error_wrap_apr(status, _("Error retrieving REPORT"));
> > + if (sess->pending_error)
> > + return sess->pending_error;
>
> This could be written more simply as:
>
> SVN_ERR(sess->pending_error);
>
> Whether that is *clearer* ... dunno :-P

I prefer Greg's suggested form on the grounds that it seems more
consistent with error handling in the rest of Subversion's source.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Fri Mar 31 20:42:04 2006

This is an archived mail posted to the Subversion Dev mailing list.