Re: [PATCH] show log message before changed paths in mailer.py

I like this change in output format, and see nothing wrong with the
patch itself.

On Wed, 29 Mar 2006, Mathias Weinert wrote:

> Hi there,
>
> I am using mailer.py quite a while now and I find it more usefull if
> the log message comes at the top of the mail, just after author, date
> and revision number but not after all the changed paths.
>
> Especially when many paths are changed with one commit I first want
> to read the log message to see what the commit is about and then scroll
> through the list of changed paths. Otherwise I have to scroll through
> the whole list without knowing at all why these paths are changed.
...
> [[[
> * tools/hook-scripts/mailer/mailer.py
> Show log message before changed paths (instead of after)
> ]]]
>
> --- tools/hook-scripts/mailer/mailer.py.orig 2005-12-15 01:57:49.000000000 +0100
> +++ tools/hook-scripts/mailer/mailer.py 2006-03-29 10:05:51.073150700 +0200
> @@ -882,8 +882,8 @@
>
> w = self.output.write
>
> - w('Author: %s\nDate: %s\nNew Revision: %s\n\n'
> - % (data.author, data.date, data.rev))
> + w('Author: %s\nDate: %s\nNew Revision: %s\n\nLog: %s\n\n'
> + % (data.author, data.date, data.rev, data.log))
>
> # print summary sections
> self._render_list('Added', data.added_data)
> @@ -900,8 +900,6 @@
> else:
> w('and changes in other areas\n')
>
> - w('\nLog:\n%s\n' % data.log)
> -
> self._render_diffs(data.diffs)
> if data.other_diffs:
> w('\nDiffs of changes in other areas also in this revision:\n')