[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.3.1 tarballs up for testing/signing (Again)

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-03-29 18:54:29 CEST

Malcolm Rowe <malcolm-svn-dev@farside.org.uk> writes:

> Does this patch help? Looks like there's a pool misuse in the test
> itself.

Yes, that's it. Obviously the test intended to pass subpool here, and
passing subpool does fix the problem, but does that indicate a bug in
the editor code? Does passing the parent pool violate the editor API?

> Index: subversion/tests/libsvn_repos/repos-test.c
> ===================================================================
> --- subversion/tests/libsvn_repos/repos-test.c (revision 19083)
> +++ subversion/tests/libsvn_repos/repos-test.c (working copy)
> @@ -1494,7 +1494,7 @@
> /* Open directory /A, to which we have read/write access. */
> SVN_ERR(editor->open_directory("/A", root_baton,
> SVN_INVALID_REVNUM,
> - pool, &dir_baton));
> + subpool, &dir_baton));
>
> /* Test denied file addition. Denied because of a conflicting rule
> on the file path itself. */

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 29 18:54:54 2006

This is an archived mail posted to the Subversion Dev mailing list.