Re: [PATCH] fix for issue 2475: ignore case for hostnames (repost)

Philip Martin <philip@codematters.co.uk> writes:

>> + for(i = 0; host_uri.hostname[i]; i++)
>> + host_uri.hostname[i] = tolower(host_uri.hostname[i]);
>> +
>> + // path will be pointing to a new memory location, so update src to
>> + // point to the new location too.
>> + offset = src - path;
>> + path = apr_uri_unparse(pool, &host_uri, APR_URI_UNP_REVEALPASSWORD);
>> + src = path + offset;
>
> Rather than overwriting host_uri and calculating a new path can you
> simply copy the lower case stuff into dst?

I see now, the unparse call is to handle things like username and
password.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org