[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix for issue 2475: ignore case for hostnames (repost)

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-03-28 22:25:20 CEST

Hi,

this patch has been sitting on the mailing list for some weeks, so I thought I
bring it back under your attention.

Previous discussion on this patch can be found here:
http://svn.haxx.se/dev/archive-2006-03/0292.shtml

In short, the issue is that hostnames should be handled in an case-insitive way.
Subversion now does all its url handling case sensitive, which leads to certain
problems, eg. moving a file/folder between working copies that point to the
same repository but with different case will fail.

I propose to resolve it as such:
1. When creating a new working copy, make sure the hostname part of the url in
the entries file is stored in lowercase.
2. When reading from an 'old' working copy, lower the case of the hostname while
reading the url. This allows us to be still backwards compatible.

This patch contains both white & blackbox tests for this issue.

thanks for committing if accepted.

Lieven.

[[[
Fix for issue #2475: Make sure hostnames in URI's are handled in a case
insenitive manner.

Patch by: Lieven Govaerts <lgo@mobsol.be>
Found by: Andy Somerville

* subversion/libsvn_subr/path.c:
  (svn_path_canonicalize): convert hostname to lowercase.

* subversion/libsvn_wc/entries.c:
  (svn_wc__atts_to_entry): while reading from the entries file,
  canonicalize url and repos.

* subversion/include/svn_path.h:
  (svn_path_canonicalize): add comment

* subversion/tests/libsvn_subr/path-test.c:
  (test_canonicalize): add test for uppercase hostnames

* subversion/tests/cmdline/path_tests.py:
  new file, contains tests for issue #2475.
]]]

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Mar 28 22:25:54 2006

This is an archived mail posted to the Subversion Dev mailing list.