[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18972 - trunk/subversion/libsvn_repos

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2006-03-28 19:32:11 CEST

dlr@tigris.org writes:

> Author: dlr
> Date: Mon Mar 20 15:35:47 2006
> New Revision: 18972
>
> Modified:
> trunk/subversion/libsvn_repos/hooks.c
>
> Log:
> Add hook script support for Windows Script Host (.wsf) files. Though
> WSH also allows for invocation of JScript (.js) and VB Script (.vbs)
> files, the file extensions for these are not explicitly enumerated
> because the languages can be run via a .wsf file.

That sort of information should go into a comment in the code, not the
log message, otherwise someone looking at the code might not
understand the rationale.

> * subversion/libsvn_repos/hooks.c
> (check_hook_cmd): Add the ".wsf" to the "check_extns" list.
>
> Patch by: Stuart Celarier <SCelarier@corillian.com>
>
>
> Modified: trunk/subversion/libsvn_repos/hooks.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_repos/hooks.c?pathrev=18972&r1=18971&r2=18972
> ==============================================================================
> --- trunk/subversion/libsvn_repos/hooks.c (original)
> +++ trunk/subversion/libsvn_repos/hooks.c Mon Mar 20 15:35:47 2006
> @@ -200,7 +200,7 @@
> static const char* const check_extns[] = {
> #ifdef WIN32
> /* For WIN32 we need to check with an added extension(s). */
> - ".exe", ".cmd", ".bat", /* ### Any other extensions? */
> + ".exe", ".cmd", ".bat", ".wsf", /* ### Any other extensions? */
> #else
> "",
> #endif

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 28 19:32:30 2006

This is an archived mail posted to the Subversion Dev mailing list.