jerenkrantz@tigris.org wrote:
> Author: jerenkrantz
> Date: Mon Mar 27 09:51:55 2006
> New Revision: 19043
>
> Modified:
> trunk/subversion/libsvn_ra_serf/commit.c
>
> Log:
> ra_serf: Pass copy test #1 (basic copy and move commands -- on files only), #30
> (copy a complex mixed-rev wc), #37 ('move --force' should not lose local mods).
>
> * subversion/libsvn_ra_serf/commit.c
> (close_file): Accept a 204 or 201 from a PUT as a valid response.
>
>
> Modified: trunk/subversion/libsvn_ra_serf/commit.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_serf/commit.c?pathrev=19043&r1=19042&r2=19043
> ==============================================================================
> --- trunk/subversion/libsvn_ra_serf/commit.c (original)
> +++ trunk/subversion/libsvn_ra_serf/commit.c Mon Mar 27 09:51:55 2006
> @@ -1436,8 +1436,7 @@
> SVN_ERR(svn_ra_serf__context_run_wait(&put_ctx->done,
> ctx->commit->session, pool));
>
> - if ((ctx->checkout && put_ctx->status != 204) ||
> - (!ctx->checkout && put_ctx->status != 201))
> + if (put_ctx->status != 204 && put_ctx->status != 201)
> {
> /* TODO Parse server-provided error code / message. */
> return svn_error_createf(SVN_ERR_FS_GENERAL, NULL,
>
Sorry if this is a newbie question, but why are you using magic numbers
instead of defined constants for the error codes?
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 27 19:58:47 2006