Re: [PATCH] Follow-up to r18536 OS400/EBCDIC Port: Convert string args to EBCDIC for functions that require it.

Julian Foad <julianfoad@btopenworld.com> wrote on 03/24/2006 07:05:27 PM:

> Paul Burba wrote:
> >
> > Index: subversion/libsvn_subr/io.c
> > ===================================================================
<snip>
> > @@ -554,8 +571,17 @@
> > dest_apr.len = rv;
> >
> > /* ### Cast needed, one of these interfaces is wrong */
> > +#ifndef AS400_UTF8
> > + /* ### Cast needed, one of these interfaces is wrong */
>
> I assume you didn't mean to duplicate that comment.

Removed dups.
 
> > SVN_ERR(svn_utf_string_to_utf8((const svn_string_t **)dest,
&dest_apr,
> > pool));
> > +#else
> > + /* The buf filled by readlink() is ebcdic encoded
> > + * despite V5R4's UTF support. */
> > + SVN_ERR(svn_utf_cstring_to_utf8_ex(&buf_utf8, dest_apr.data,
> > + (const char *)0, NULL, pool));
>
> I think you meant to use that new constant you defined above, instead of
NULL
> here. (Probably thinking about that other patch that might make the arg

> redundant...)

That's what I did, fixed that.
 
> > + *dest = svn_string_create(buf_utf8, pool);
> > +#endif
> >
> > return SVN_NO_ERROR;
> > #else
>
> - Julian

Thanks for taking a look,

Paul B.

[[[
OS400/EBCDIC Port: Convert string args to EBCDIC for functions that
require it.

This is a follow-up to r18536, one of several patches to allow
Subversion to run on IBM's OS400 V5R4. Rev 18536 mistakenly didn't
include all the changes necessary to handle EBCDIC arguments to
symlink() and readlink(). This patch fixes that.

* subversion/libsvn_subr/io.c
   (SVN_UTF_ETOU_XLATE_HANDLE): New xlate key for EBCDIC (CCSID 0) to
    UTF-8 (CCSID 1208) string conversions.
   (svn_io_create_unique_link): Convert *both* string args to
    symlink() to EBCDIC.
   (svn_io_read_link): Convert the buffer filled by readlink() from
    EBCDIC to UTF-8.
]]]

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org