[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't use XFAIL for unwritten tests; also rm redundant test runs

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-03-27 03:32:19 CEST

Ben Collins-Sussman wrote:
> On 3/26/06, Julian Foad <julianfoad@btopenworld.com> wrote:
>
>> "XFail" is intended to mean that a test is failing because of a known bug or
>> deficiency in Subversion. I noticed that some tests were using it as a way of
>> inserting a place-holder for a test which might one day be written. This patch
>> removes those place-holders.
>>
>> There's one possible ill effect: the test index numbers of some existing tests
>> are changed by this patch.
>>
>
> Why not just Skip() the test-stubs, rather than outright delete them?
> Wouldn't that be a lot less disruptive?
>
Changing test numbers are not a problem, especially as we have test
descriptions, too.

Tests that aren't implemented should either be deleted, or succeed. I
think the latter is the worse choice.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 27 03:32:35 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.