Julian Foad <email@example.com> wrote on 03/22/2006 05:40:09 PM:
> Paul Burba wrote:
> > My description of these is likely not clear enough. They are keys for
> > caching xlate_handle_node_t structs for conversions between EBCDIC and
> > UTF-8 and vice-versa when calling svn_utf_cstring_to_utf8_ex() and
> > svn_utf_cstring_from_utf8_ex(), i.e. the convset_key argument to these
> > functions. I've tried to improve the comments for these in the
> > patch.
> Thanks for the further info. I've posted a request for more info about
> usage in those function calls as I don't think those functions are
> documented. I'm not sure that we need or want to make these things
> part of the
> public API, but you can just do something that works for now and we
> can resolve
> the theoretical issue in due course.
> As for the issue of where/how to define the char-set-conversion
> cache keys, go
> with whatever seems to be the best way of defining them for now. If
> we want to
> change it later (e.g. make them private), then we can change it later.
For now it seems safest to not make these public until the larger
questions regarding svn_utf_cstring_*_utf8_ex() are resolved. To that end
I changed the patch so it exclusively deals only with the hook script
problem. The two calls to svn_utf_cstring_*_utf8_ex() in hooks.c now use
string literals for the convset_key args.
> There are a few other style nits (open-paren at EOL, space before
> space at EOL) if you care to look for them, but they are unimportant.
> I can't see any logic problems at all.
> With the redundant initialisers removed, +1 to commit, with or without
> trivial style fixes.
I fixed (hopefully all) the style problems. Unless anyone objects to the
changes regarding conversion set keys I'll commit this this afternoon.
This is one of several patches to allow Subversion to run on IBM's
OS400 V5R4. It provides a workaround for various limitations with
IBM's implementation of APR processes.
Include spawn.h and fcntl.h
(run_hook_cmd): New "APR-free" implementation for OS400.
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
Received on Thu Mar 23 18:14:01 2006
To unsubscribe, e-mail: firstname.lastname@example.org
For additional commands, e-mail: email@example.com