[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18932 - trunk/subversion/include

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-03-23 02:22:41 CET

Ivan Zhakov wrote:
> Anyway I didn't see reasons why we cannot leave
> svn_xml_is_ascii_xml_name in our public API? We already have function
> svn_xml_is_xml_safe().

The reason we should not rename it to svn_xml_is_ascii_xml_name() and leave it
in our public API is because we have no reason to believe that any caller would
want to use such a function. The only caller we currently have,
is_valid_prop_name(), does not "want" to use that function. It only uses it
because nothing better is available yet.

> I don't press for keep it, so revert my commit if you consider.

Thanks. I've reverted it in r18995.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 23 02:23:30 2006

This is an archived mail posted to the Subversion Dev mailing list.