Re: svn commit: r18932 - trunk/subversion/include

Ivan Zhakov writes:
> At the moment when I commited this change, it was only one usage of
> svn_ctype out of libsvn_subr module. I was going to deprecated
> svn_ctype_table, but this requires function call for each access,
> which could decrease performance.

The problem is that svn_ctype_* are meant to be used, and we can't
just move all uses inside libsvn_subr.

> Anyway I didn't see reasons why we cannot leave
> svn_xml_is_ascii_xml_name in our public API? We already have function
> svn_xml_is_xml_safe().

It is an ugly incomplete API that has no place in our public APIs.

> I don't press for keep it, so revert my commit if you consider.
>
Let's get that done before 1.4 (or reimplement it to support the full
XML character repertoire).

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 20 22:19:56 2006