Re: Ruby test failure

On Mon, Mar 20, 2006 at 09:32:34AM +0900, Kouhei Sutou wrote:
> > Okay, so now if r2c_swig_type2() fails, we will now raise an error,
> > but svn_swig_rb_get_pool() will still dereference pool_wrapper regardless,
> > won't it?
>
> Yes. Because svn_swig_rb_get_pool() uses r2c_swig_type2(),
> svn_swig_rb_get_pool() will raises an error without checking
> in svn_swig_rb_get_pool().
>

I'm not quite sure if you're agreeing with me (I'm not sure what 'raises
an error without checking' means); if you're not, could you explain a
bit more?

Shouldn't we be checking for a failure from calling r2c_swig_type2()?
Or if it's 'never going to happen', at least set *result to NULL after
we call SWIG_Error(), so that we'll get a more predictable crash later?

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 20 14:40:12 2006