[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix mailer.py show_nonmatching_paths blowup

From: Robert Spier <rspier_at_pobox.com>
Date: 2006-03-18 19:53:03 CET

Rationale: with show_nonmatching_paths set to yes, and a
configuration to send commit messages to multiple places, a
AttributeError: DiffGenerator instance has no attribute 'diff' would
be triggered in _render_diffs because it would never be added to the
instance. This sets a default value of None. (This is cleaner than
adding lots of has_attr checks to _render_diffs.) I also discovered
that I really wanted show_nonmatching_paths=summary. ;)

-R

   * tools/look-scripts/mailer/mailer.py: ensure diff and diff_url
     properties exist on the DiffGenerator instances.
    
--- subversion/tools/hook-scripts/mailer/mailer.py 2006-02-19 20:42:20.000000000 -0800
+++ mailer.py 2006-03-18 10:43:37.000000000 -0800
@@ -665,6 +665,8 @@
     self.diffurls = diffurls
     self.pool = pool
 
+ self.diff = self.diff_url = None
+
     self.idx = 0
 
   def __nonzero__(self):

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 18 19:54:00 2006

This is an archived mail posted to the Subversion Dev mailing list.