On 3/13/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> Ivan Zhakov writes:
> > On 3/13/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > > Maybe it is a
> > > good idea to get rid of the read_all parameter of the
> > > svn_stream_content_same function and instead create a new stream that
> > > will "drain" its underlying stream when it is being closed. Thoughts?
> > Yeah, I had similiar idea recently. But in this case we need extra
> > allocations of read buffer. I don't know how it decrease performance.
>
> Keep a flag whether the end of stream was reached. On close, if EOS
> wasn't reached, just allocate a buffer and drain the stream. So you
> only need the buffer if the reading was stopped early.
>
Or might be add this flag to svn_stream_checksummed() ?
I will be busy in near time therefore I cannot fix it.
--
Ivan Zhakov
Received on Fri Mar 17 16:48:45 2006