[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] more typo/wording fixes

From: Ed Price <ed.price_at_gmail.com>
Date: 2006-03-11 04:51:38 CET

Julian Foad:
> Yes, fair enough, inconsistency is annoying, but it's not worth making a
> separate commit for it - revision numbers are cheap but not THAT cheap - so
> I've added it to my pending diff file of all sorts of trivial fixes in comments.
>
> Committed in r18658, as it was about time to flush my queue.

Thank you. (And I will batch changes.)

Also, thank you for replying to my other question about acronym
capitalization.

Actually, I realize now that "properly" capitalizing acronyms in all
comments would conflict badly with what appears to be commonly
followed (internal) comment style in which parameter names are written
in all caps. For example:

/* Tweak the entry NAME within hash ENTRIES. If NEW_URL is non-null,
 * make this the entry's new url. If NEW_REV is valid, [...]

Changing "url" to "URL" there would be a bad idea.

I originally looked in hacking.html for guidance on comment style, and
was surprised not to find any. However, it seems that most comments
are well-written. I very much appreciate the care which is generally
taken by Subversion developers in all aspects of the project.

-Ed

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 11 04:51:52 2006

This is an archived mail posted to the Subversion Dev mailing list.