[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [DOCFIX] Fix ambiguous comments for svn_string_isempty()

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-03-09 14:42:11 CET

Madan U S wrote:
> [[[
> Remove ambiguity in wc/workarea/subversion/include/svn_string.h
>
> * wc/workarea/subversion/include/svn_string.h (svn_string_isempty):
> Modified comment to remove ambiguity.
> ]]]
> -/** Return true if a bytestring is empty (has length zero). */
> +/** Return non-zero value if a bytestring is empty (has length zero). */
> svn_boolean_t svn_string_isempty(const svn_string_t *str);

Thanks for the suggestion, but that change is not necessary because "true"
already means "non-zero" in C.

(I much prefer "true" over "non-zero" or "@c TRUE", as truth values are so
commonly used that there should be no need to distract the reader by
emphasising at every point the particular implementation used for it.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 9 14:43:57 2006

This is an archived mail posted to the Subversion Dev mailing list.