[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Flush stdout more often

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-03-07 13:55:14 CET

Max Bowsher writes:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Since our command-line client output is line-structured, it seems to me
> that it ought to be line-buffered, and the fact that it is not, at the
> moment, is a bug.
>
Not everywhere, as has been pointed out earlier. diff/cat/blame are
examples where flushing after each lines doesn't make sense.

For notifications, yes, since the whole point of notification is to
give the user instant feedback. For status, also yes, because it will
often wait for the network (status -u) and there is no point in having
the next process in the pipe wait when there is more data it could
process.

I never understood Justin's argument about cruft. It is a few
one-liner changes to add fflush calls. That can't be a maintenance
burden worth worryihg about.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 7 13:56:27 2006

This is an archived mail posted to the Subversion Dev mailing list.