[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc losing properties?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-03-07 08:32:09 CET

Justin Erenkrantz writes:
> Index: subversion/libsvn_wc/props.c
> ===================================================================
> --- subversion/libsvn_wc/props.c (revision 18738)
> +++ subversion/libsvn_wc/props.c (working copy)
> @@ -410,9 +410,9 @@
> SVN_ERR(svn_wc__loggy_set_readonly(log_accum, adm_access,
> real_props, pool));
> }
> - else
> + else if (!tmp_entry.has_props)
> {
> - /* No property modifications, remove the file instead. */
> + /* No property modifications and no more props, remove the file. */
> SVN_ERR(svn_wc__loggy_remove(log_accum, adm_access, real_props, pool));
> }

This sounds like a regression introduced by wc-propcaching. Your
solution isn't correct, because one of the main points of
wc-propcaching was to not have a working props file when there are no
property *changes*:-) I'll have a look tonight if possible.

Thanks for finding this, Justin,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 7 08:33:12 2006

This is an archived mail posted to the Subversion Dev mailing list.