[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch to neon library detection code.

From: Paul de Vrieze <pauldv_at_gentoo.org>
Date: 2006-03-03 11:00:16 CET

On Wednesday 01 March 2006 08:18, Daniel Rall wrote:
> The only difference between this new macro and the pre-existing
> SVN_DOWNLOAD_NEON() macro is the use of AC_MSG_FAILURE()
> vs. AC_MSG_RESULT(). The names of these macros should reflect the
> differences -- something like SVN_DOWNLOAD_NEON_AND_FAIL() would be a
> better name for the new macro.
>
> These macros could also be better factored. How about use of a shared
> helper macro which contains the 'echo' of all that text to avoid so
> much duplication?

You're right. I'll look into refactoring it appropriately.

Paul 

-- 
Paul de Vrieze
Gentoo Developer
Mail: pauldv@gentoo.org
Homepage: http://www.devrieze.net

  • application/pgp-signature attachment: stored
Received on Fri Mar 3 11:01:08 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.