[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] next-id to next-key

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-03-02 16:34:53 CET

Kamesh Jayachandran wrote:
> Hi All,
> While trying to understand the bdb schema found small issues with the doc.
>
> The attached patch fixes them.
>
> [[[
> Typo fixes to bdb repos doc on structure
>
> Patch by: Kamesh Jayachandran <kamesh@collab.net>
>
> * subversion/libsvn_fs_base/notes/structure
> Bdb tables nodes, transactions, copies, strings, representations use
> a record with a key 'next-key' to make use as 'key' for further
> insertions.
> The doc says 'next-id' rather than 'next-key'.
>
> ]]]

Committed.
   Sending subversion/libsvn_fs_base/notes/structure
   Transmitting file data .
   Committed revision 18686.

I made a small tweak though. See below.

> Berkeley DB tables
> ------------------
>
> - "nodes" : btree(ID -> NODE-REVISION)
> + "nodes" : btree(ID -> NODE-REVISION, "next-key" -> next unused node id)

I replaced "next unused node id" with "NODE-ID", which was more
consistent with the other "next-key" mappings in the BNF, and also made
the line fit in 80 columns.

Thanks for the patch, Kamesh.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Mar 2 16:44:19 2006

This is an archived mail posted to the Subversion Dev mailing list.