[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18649 - trunk/contrib/client-side

From: Giovanni Bajo <rasky_at_develer.com>
Date: 2006-03-02 15:18:55 CET

David James <djames@collab.net> wrote:

>> I guess the correct solution is to put defaults for all the common
>> within the state dictionary, no matter which ones are actually valid for
>> the current command. The code that sets the defaults is currently in
>> _fancy_getopt. Can you move it into parse() (near the beginning) and run
>> it for all the global options (self.gopts) + all the common options
>> (self.copts)? That should make it. Or get back to me and I'll try to fix
>> it myself.
> That sounds good -- would you like to do this?

In the end, I went for a different solution (more similar to yours), see
r18683. If analyze_revs needs a bidirectional flag, it should declare it
among its parameters, not rely on the global settings. The global opts
dictionary is a relic of the straightforward conversion from the shell
script, and should be removed. Ideally, each action_*() function would get
its opts dictionary as an argument.


Giovanni Bajo
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 2 15:22:25 2006

This is an archived mail posted to the Subversion Dev mailing list.