Alexander Kitaev wrote:
>> There shouldn't be any \r's in the svn:log value in the first
>> place; they're supposed to be filtered out by the client. So
>> the first question is, where are they coming from?
> I'm setting those messages programatically through JavaSVN (actually I'm
> doing commit and commit message includes \r's). I understand your point and
> agree that client should convert commit message not to contain \r's before
> making a commit.
>
> On the other side, as far as I understand, svn:log is not special kind of
> property (except that it is set automatically on commit), so it should be
> possible to set it to any value in any encoding or even binary data as well
> as any other revision property (probably doing "svn propset -rX --revprop
> svn:log -F fileWithWindowsEols" will do the same). Svnserve behaves
> consistently here, preserving svn:log property value in log message, but
> mod_dav_svn does not (the log message it reports is not same as the value
> stored in revprop file of the corresponding revision).
That's not quite true: the svn:log property is (like all other svn:
properties) a Subversion property. And all Subversion properties *must*
be in UTF8 and LF lineendings (as defined in the docs). A client must
make sure that this is done right.
If it were another property, *then* you're allowed to store whatever you
want in whichever format you like, even with CRLF lineendings or binary
data. But not with svn: properties.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 20:18:36 2006