[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Eols are not preserved in DAV log reponse.

From: Alexander Kitaev <alex_at_tmate.org>
Date: 2006-02-28 19:43:32 CET

Hello Stefan,

> So if you could commit a log message with CRLF lineendings,
> that's the fault of the Subversion client which didn't
> convert the log message.
Now it is JavaSVN bug. But what if one will set "invalid" svn:log value with
"svn propset --revprop"? Should svn:log value be converted by the client in
this case as well?

Alexander Kitaev,
TMate Software,
http://tmate.org/
http://jetbrains.com/tmate/

> -----Original Message-----
> From: Stefan Kung [mailto:tortoisesvn@gmail.com]
> Sent: Tuesday, February 28, 2006 19:05
> To: dev@subversion.tigris.org
> Subject: Re: Eols are not preserved in DAV log reponse.
>
> Alexander Kitaev wrote:
>
> > I've noticed a difference between mod_dav_svn responses to
> > getRevisionProperty("svn:log") and log(...):
> >
> > Fetching revision property:
> >
> > <S:log>changes from 0.9.0 merged (1116:1155):&#13; &#13;
> > - export and swtich fixes&#13;
> > .....
> >
> > Fetching log (history):
> >
> > <D:comment>changes from 0.9.0 merged (1116:1155):
> >
> > - export and swtich fixes
> > .....
> >
> > As you could see, in "log" response real eols (those stored in
> > corresponding revprop file, in this case \r\n) are replaced
> with \n.
> > When using "svn" or "file" protocol, eols are reported
> correctly. Is this a known problem?
>
> With which client did you commit that revision?
> I'm asking because the docs of svn_client_get_commit_log2()
> clearly state:
> "The log message MUST be a UTF8 string with LF line separators."
>
> So if you could commit a log message with CRLF lineendings,
> that's the fault of the Subversion client which didn't
> convert the log message.
>
> (I know TSVN had this bug once, but it got fixed in revision
> 847 which was before version 1.0.1 almost two years ago).
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest Interface to (Sub)Version Control
> /_/ \_\ http://tortoisesvn.tigris.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 20:04:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.