Re: [PATCH] Next rev of Windows service support (Feb 27)

Malcolm Rowe wrote:
> On Tue, Feb 28, 2006 at 05:48:55PM +0300, Ivan Zhakov wrote:
>
>>> +svn_error_t* winservice_start()
>>>
>> Same as previous: "svn_error_t *winservice_start()"
>>
>>
>
> That, and we usually line-break after the '*':
>
> svn_error_t *
> winservice_start()
>
> I assume this isn't static because the SCM calls it directly?
>
It's not static because it's called from main().

> Shouldn't that be winservice_start(void)? This isn't C++, is it?
>
My goodness, you're right. I missed that.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 19:40:33 2006