Re: [PATCH] Next rev of Windows service support (Feb 27)

Arlie Davis wrote:
>> +#include <arch/win32/apr_arch_networkio.h>
>> I consider we don't need this. See below.
>>
>
> It's necessary for the apr_os_get_sock call. I tried removing
> this #include, and it would not compile.
>
apr_os_sock_get is declared in apr_portable.h and defined (out of line)
in network_io/<arch>/sockets.c. You really shouldn't need this
arch-specific include.

> Ivan, Branko - Do you want me to make these edits and resubmit the patch,
> or not? And again, thanks for the review.
>
Not as far as I'm concerned. Since I'll happily do the reformatting of
winservice.c, dong the tweaks we agreed upon here won't take that much
extra time.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 18:43:04 2006