Paul Burba wrote:
> [[[
> OS400/EBCDIC Port:
Were you meaning to put something like "Disable unsupported features." after
the colon?
> This is one of several patches to allow Subversion to run on IBM's
> OS400 V5R4. It disables subcommands and CL options not currently
> supported on OS400.
>
> * subversion/svn/main.c
> (svn_cl__options): Disable --encoding, --editor-cmd, --diff-cmd,
> --diff3-cmd, and --extensions options.
> (svn_cl__cmd_table): Tweak svn ci help message. Disable svn
> propedit.
> ]]]
> - { "commit", svn_cl__commit, {"ci"}, N_
> - ("Send changes from your working copy to the repository.\n"
> + { "commit", svn_cl__commit, {"ci"},
> +#ifndef AS400
> + N_("Send changes from your working copy to the repository.\n"
> "usage: commit [PATH...]\n"
> "\n"
> " A log message must be provided, but it can be empty. If it is not\n"
> " given by a --message or --file option, an editor will be started.\n"
> " If any targets are (or contain) locked items, those will be\n"
> " unlocked after a successful commit.\n"),
> +#else
> + N_("Send changes from your working copy to the repository.\n"
> + "usage: commit [PATH...]\n"
> + "\n"
> + " A log message must be provided, but it can be empty.\n"
> + " OS400 does not support the starting of an editor,\n"
> + " so --message or --file must be used. If any targets are\n"
> + " (or contain) locked items, those will be unlocked after a\n"
> + " successful commit.\n"),
> +#endif
Heh! To begin with I thought it would be nice if you could put the "#if"
around just the part of the string that differs, but then I realised that would
be trying to use a directive inside the invocation of a macro, so impossible.
Please could you reindent the existing text strings to match the new position
of the opening parenthesis?
Does something suitable happen if the user doesn't provide "--message" or "--file"?
Other than that, +1.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 28 03:01:19 2006